Add sample versions in extraDevfileEntries.yaml #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <[email protected]>
thepetk
requested review from
johnmcollier,
michael-valdron,
maysunfaisal and
kim-tsao
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR is the last step to the support of multiple sample versions inside the
extraDevfileEntries.yaml. This feature will allow us to support samples with parents using outerloop and to have more consistent ports.As a result all entries inside the
extraDevfileEntries.yamlhave been updated to have versions. Other than that the 3 samples that have a parent supporting outerloop now have an extra version. Those are:go-basic: We have added version2.0.0in order to support the outerloopgostack versions.python-basic: We have added version2.0.0in order to support the outerlooppythonstack versions.java-springboot-basic: We have added version2.0.0in order to support the outerloopjava-springbootstack versions.Which issue(s) this PR fixes:
fixes devfile/api#1112
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
Some notes for the consumers of the registry:
ODCis using the/index/sampleendpoint which will only return the default (old) versions of each sample.RHTAPis using the/index/sampleendpoint which will only return the default (old) versions of each sample.odois not using the devfile samples.For
RHTAPI've tried to update locally the mock-devfile-data.ts with the updatedindex/sample(only thegit.revisionis added) and ran the tests. The tests were ok.For
ODCI've started a console server locally (CRC) using minikube & a build of the updated registry.